Repository navigation
mcp: cancel pending keepalive ping when the session closes - #1478
Merged
guglielmo-san merged 1 commit intoOct 29, 2026
Merged
guglielmo-san merged 1 commit into
guglielmo-san merged 1 commit into
Conversation
startKeepalive derived each ping's context from context.Background, so cancelling the keepalive did not reach a ping already in flight. Closing a session whose peer had stopped answering, such as on a client DELETE, then waited up to KeepAlive/2 for the ping to time out and logged it as a keepalive failure. Derive the ping context from the keepalive context, and stop the loop without counting a failure when that context has been cancelled. Fixes #1470
guglielmo-san
approved these changes
Oct 29, 2026
Contributor
|
@vshalpnjabi thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startKeepalive derived each ping's context from context.Background, so stopping the keepalive didn't reach a ping already in flight. Closing a session whose peer had stopped answering (for example on a client DELETE) then waited up to KeepAlive/2 for the ping to time out and logged it as a keepalive failure.
This derives the ping context from the keepalive context and stops the loop without counting a failure when that context is cancelled. TestStartKeepalive_CancelStopsPendingPing covers both parts: it fails without the change, and still fails with only the context change.
With the repro from the issue, the DELETE now returns in about 1ms instead of 1.001s, with nothing logged. go test ./... and go vet ./... pass.
Fixes #1470
AI-assisted; I reviewed the full diff and ran the tests myself.