Repository navigation
mcp: document and test explicit subscriptions/listen calls - #1475
Closed
IAmSurajBobade wants to merge 1 commit into
Closed
IAmSurajBobade wants to merge 1 commit into
IAmSurajBobade wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
missing-issue-link
Contributor
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #1474. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned. There's no need to open a new PR either way. Maintainers: reopen, remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallCustomMethod already supports registered standard requests, but its documentation requires custom registration, which rejects standard method names. Document explicit subscriptions/listen invocation using native SDK types, acknowledgement middleware, cancellation, and interaction with automatic subscriptions.
Add regression test coverage for notification delivery, subscription identity, cancellation without closing the session, successful completion, and JSON-RPC errors. No runtime implementation, exported signatures, or dependencies change.
Validation: go test -race ./... -timeout=5m, focused tests repeated ten times, go vet ./..., and documentation regeneration passed.
Fixes #1474