Repository navigation
Conversation
This was referenced Aug 8, 2026
This comment was marked as spam.
This comment was marked as spam.
Contributor
|
Duplicate of #1469 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
processResultresponse write failures throughOnInternalErrorinstead of dropping them.Fixes #1147.
Motivation
When a handler finishes after the client has already torn down the stream (e.g. client-side timeout),
c.writefails and that error was discarded. Server logs then look like nothing happened. Maintainer guidance on the issue was to log at that site; MCP already wiresOnInternalErrortosloginmcp/transport.go.Test plan
go test ./internal/jsonrpc2/ -run TestProcessResultWriteFailureReportsInternalErrorgo test ./internal/jsonrpc2/...