WIP: mcp: support custom notifications - #1146
Open
delaneyj wants to merge 1 commit into
Open
Conversation
Protocol extensions can define custom JSON-RPC notifications, but the SDK only exposes helpers for standard notifications. Add SendNotification to client and server sessions. Route custom notifications through sending middleware and preserve arbitrary parameters. Fixes modelcontextprotocol#745.
delaneyj
force-pushed
the
custom-notifications
branch
from
August 5, 2026 14:37
99154e6 to
6863d59
Compare
delaneyj
marked this pull request as ready for review
August 5, 2026 15:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol extensions can send custom JSON-RPC notifications. The SDK session APIs provide methods only for standard notifications.
This change adds
SendNotificationtoClientSessionandServerSession. Sending middleware processes each custom notification before transmission.The implementation preserves arbitrary parameters. It encodes nil parameters as an empty JSON object.
This PR supersedes #844. It updates that implementation for the current
Params.isNilinterface and adds wire-level tests.Tests cover:
Tests:
Fixes #745