mcp: add ServerOptions.DefaultCacheable - #1128
Open
arimu1 wants to merge 3 commits into
Open
Conversation
| } | ||
| } | ||
|
|
||
| func TestSetDefaultCacheableValues(t *testing.T) { |
Contributor
There was a problem hiding this comment.
lets remove this test
Contributor
Author
|
Removed |
arimu1
force-pushed
the
fix/1094-default-cacheable
branch
from
August 3, 2026 23:31
7d4f460 to
7a5a2c0
Compare
Comment on lines
+1197
to
+1202
| func (c *Cacheable) setDefaultCacheableValues(defaults *Cacheable) { | ||
| if defaults != nil { | ||
| c.TTLMs = defaults.TTLMs | ||
| c.CacheScope = defaults.CacheScope | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
the issue here is that if defaults does not set the CacheScope, it will not be set to public
Allow servers to override the Cacheable defaults stamped on SDK-generated results (discover, list methods, resources/read). Nil keeps historical public/0 defaults. Fixes modelcontextprotocol#1094
ServerOptions.DefaultCacheable may set only TTLMs. Empty CacheScope on defaults must still fall back to "public" instead of stamping "". Signed-off-by: arimu1 <19286898+arimu1@users.noreply.github.com>
arimu1
force-pushed
the
fix/1094-default-cacheable
branch
from
August 4, 2026 14:27
7a5a2c0 to
393674c
Compare
Contributor
Author
|
@guglielmo-san Thanks — fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ServerOptions.DefaultCacheable *Cacheableso multi-tenant / private servers can override the SDK's forced cacheable defaults (cacheScope: "public",ttlMs: 0) on SDK-generated results.setDefaultCacheableValuesonserver/discover,tools/list,prompts/list,resources/list,resources/templates/list, andresources/read(after the handler returns).Cacheableper result after the SDK stamps values (useful for per-request / per-tenant policy).Fixes #1094
Motivation
Servers whose list/discover payloads are tenant-scoped want
private(and a real TTL) as the SDK baseline, not only via post-hoc middleware type-switches. A single option covers all current SDK stamp sites and any future call sites that use the same helper.Test plan
go test ./mcp/ -run 'TestServerDefaultCacheable|TestSetDefaultCacheableValues' -count=1go test ./mcp/ -count=1go test ./... -count=1DefaultCacheableis nilprivate/60s stamped on list + read results when setTTLMs(read handler) while forcingCacheScope: "public"