fix(tier-check): swap server/client scenario lists in conformance reconciliation#263
Open
blackwell-systems wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
…onciliation checkConformance (server check) was reconciling results against the client scenario list, and checkClientConformance (client check) was reconciling against the server scenario list. Since server scenario names (e.g. "initialize", "tools_call") have zero overlap with client scenario names (e.g. "server-initialize", "tools-list"), every passed scenario was counted as "missing" and tier-check reported 0%. Swap the scenario list functions so each check reconciles against its own scenario type. Fixes modelcontextprotocol#182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tier-checkreports 0% server conformance even when all server tests pass becausecheckConformance(server check) reconciles results against the client scenario list, andcheckClientConformance(client check) reconciles against the server scenario list.Server scenario names (
initialize,tools_call, etc.) have zero overlap with client scenario names (server-initialize,tools-list, etc.), so every passed scenario is counted as "missing."Fix
Swap the scenario list functions so each check reconciles against its own scenario type:
checkConformancenow useslistScenarios()/listScenariosForSpec()(server scenarios)checkClientConformancenow useslistActiveClientScenarios()/listClientScenariosForSpec()(client scenarios)Fixes #182