ModCluster Management Protocol (MCMP) reimplementation#385
Open
jajik wants to merge 13 commits into
Open
Conversation
jajik
force-pushed
the
mcmp
branch
2 times, most recently
from
c9e4b89 to
c5bdc1e
Compare
In case a parameter's value was defined but evaluated false, it was ignored.
* tweak logging * rework the ping routine * simplify code a little bit * improve variable naming, drop unused parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #380
This PR rewrites parts of the MCMP and changes its behaviour in several cases and adds a set of tests to make sure the behaviour is correct.
Highlights:
What this PR does not include:
I'll share a doc with more information in our team channel.
Side note: It seems this also resolves the instability we were seeing with the MODCLUSTER-736 test (or it's just the weather).It was the weather 🙂Side note 2: I ran the perf suite with the changes as a smoke test, it looks ok (2 tomcats with 1 disable, 20 tomcats with 10 disable, 20 tomcats with 10 shutdown, 20 tomcats with 10 kill, 20 tomcats with 10 stop)