Skip to content

chore: update serialize-javascript package #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmegidish merged 1 commit into from
Apr 27, 2026
Merged

chore: update serialize-javascript package #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 5 additions & 36 deletions test/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,8 @@
"mocha": "^11.7.2",
"ts-node": "^10.9.2",
"typescript": "^5.9.2"
},
"overrides": {
"serialize-javascript": "^7.0.3"
Comment on lines +28 to +29
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify serialize-javascript version and check for security advisories

# Check if version 7.0.3 exists on npm registry
echo "Checking npm registry for serialize-javascript versions..."
curl -s https://registry.npmjs.org/serialize-javascript | jq -r '.versions | keys[] | select(startswith("7.0"))' | sort -V

# Check the latest version
echo -e "\nLatest version:"
curl -s https://registry.npmjs.org/serialize-javascript | jq -r '.["dist-tags"].latest'

# Check for security advisories
echo -e "\nChecking for security advisories..."
gh api graphql -f query='
{
  securityVulnerabilities(first: 10, ecosystem: NPM, package: "serialize-javascript") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
      firstPatchedVersion {
        identifier
      }
    }
  }
}'

Repository: mobile-next/mobilecli

Length of output: 1440

Update to serialize-javascript@^7.0.5 to fix all known vulnerabilities.

Version 7.0.3 exists and fixes the HIGH severity RCE vulnerability (patched in 7.0.3), but a newer MODERATE severity CPU Exhaustion DoS vulnerability (CVE in serialize-javascript < 7.0.5) is patched in version 7.0.5 (released 2026-03-27). Update the override from ^7.0.3 to ^7.0.5 to ensure all known vulnerabilities are addressed.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@test/package.json` around lines 28 - 29, The overrides entry for
"serialize-javascript" pins a vulnerable version; update the override value
under the JSON "overrides" object for the "serialize-javascript" key from
"^7.0.3" to "^7.0.5" so the dependency uses the patch that fixes the CVE (CPU
exhaustion DoS) released in 7.0.5.

}
}
Loading