Skip to content

BUG: Exclude bad channels in annotate_muscle_zscore - #14418

Open
BabaSanfour wants to merge 3 commits into
mne-tools:mainfrom
BabaSanfour:fix-muscle-zscore-bads
Open

BabaSanfour wants to merge 3 commits into
mne-tools:mainfrom
BabaSanfour:fix-muscle-zscore-bads

Conversation

@BabaSanfour

Copy link
Copy Markdown
Member

Reference issue

There is no existing issue for this bug but #13946 and #12402 are linked. @drammock explicitly asked for this (#11907 (comment)) during the API migration. This one was missed, I found it while working on my data. A similar fix was done here #13266

What does this fix?

Additional information

AI disclosure
Claude Opus 5.5 was used for tracing the regression to #11907 through git history and the GitHub discussion + write the test.

@BabaSanfour

Copy link
Copy Markdown
Member Author

the test failure is not linked to my changes.

@CarinaFo CarinaFo left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't think of a situation where we would want bad channels in annotate_muscle_zscore, so +1 for merge.
The default behaviour of picks and exclude is still TBD, but dipole fitting on evokeds with bad channels does not seem like a good idea, so I agree that the default there should probably be exclude.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants