Fix hemis generation in test_vertex_to_mni_fs_nibabel to cover both - #14183
Open
marcus-campbell wants to merge 1 commit into
Open
Fix hemis generation in test_vertex_to_mni_fs_nibabel to cover both#14183marcus-campbell wants to merge 1 commit into
marcus-campbell wants to merge 1 commit into
Conversation
hemispheres rng.integers(0, 1) always returns 0, so the test only compared coordinates for the left hemisphere. Use rng.integers(0, 2) so left and right hemispheres are both tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
I wasn't able to find an existing issue for this bug.
What does this implement/fix?
This fixes
test_vertex_to_mni_fs_nibabelso that it covers both hemispheres.rng.integers(0, 1)always returns 0 (exclusive upper bound), sohemiswas all zeros and the test only compared left-hemisphere coordinates. Changed torng.integers(0, 2)so the right hemisphere is exercised too.Test-only change; the seeded RNG keeps it deterministic.
Additional information
AI Disclosure: I didn't actually use AI to write any code or comments here, but I technically found this bug during an AI-assisted static analysis project that I've been working on. The AI assisting me was OpenAI Codex gpt-5.6-sol (xhigh). Just stating that for transparency; maintainers, just yell if this disclosure is too pedantic.