Allow Xdawn to be used with rank-deficient data without reg - #14182
Open
larsoner wants to merge 1 commit into
Open
Allow Xdawn to be used with rank-deficient data without reg#14182larsoner wants to merge 1 commit into
larsoner wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some rank-deficient data that I want to apply Xdawn to, but just regularizing isn't as clean as operating in the proper subspace. This PR adds the option of operating in that subspace (which then also enables using no reg for rank-deficient data). The change ended up being quite simple, mostly swapping
np.linalg.eighwith_smart_eighand somerank="full"s torank=rank. Changes drafted by Claude Opus 5 and reviewed and tested (on real data / my use case!) by me. Includes a littleAGENTS.mdtweak to facilitate changelog entry numbering by agents.Relevant to a point in #13392 but doesn't close it