MAINT: add OPM overlap grouping helper#13847
Open
PragnyaKhandelwal wants to merge 2 commits intomne-tools:mainfrom
Open
MAINT: add OPM overlap grouping helper#13847PragnyaKhandelwal wants to merge 2 commits intomne-tools:mainfrom
PragnyaKhandelwal wants to merge 2 commits intomne-tools:mainfrom
Conversation
PragnyaKhandelwal
requested review from
agramfort,
drammock and
larsoner
as code owners
Contributor
Author
|
Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Follow-up groundwork for #13781 after the merged regression PRs #13825 and #13842.
What does this implement/fix?
-Adds a small internal helper for splitting colocated OPM overlap sets into
radialandtangentialgroups-Adds a fixture-based regression test covering the grouping logic using synthetic
triaxial OPMdataAdditional information
This is the core preparation step for the remaining OPM topomap grouping work. The caller-facing plotting integration will follow in a separate PR.