[Improvement] Separate S3 storage configuration for MLRun and Kubeflow Pipeline#295
Open
GiladShapira94 wants to merge 25 commits into
Open
[Improvement] Separate S3 storage configuration for MLRun and Kubeflow Pipeline#295GiladShapira94 wants to merge 25 commits into
GiladShapira94 wants to merge 25 commits into
Conversation
Test CE Workflos
[Fix] Seaweed Change
# Conflicts: # .github/workflows/release.yml # charts/mlrun-ce/Chart.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Introduces explicit, independent S3 storage configuration for Kubeflow Pipelines under
pipelines.storage.s3.*, decoupling it from thestorage.s3.*block used by MLRun and Jupyter.Previously, all three components shared a single S3 config, making it impossible to grant scoped IAM credentials or use separate buckets without silently misconfiguring them.
Both blocks default to the bundled SeaweedFS, so default installs are unaffected - users change only the block for the component they want to redirect.
Also fixes a latent inconsistency where MLRun artifact paths were resolved from
global.infrastructure.aws.bucketName(defaulting to the hardcoded string"mlrun") rather thanstorage.s3.bucket, meaning a user changingstorage.s3.bucketwould not see that reflected inMLRUN_ARTIFACT_PATH,MLRUN_FEATURE_STORE__DATA_PREFIXES__DEFAULT, or model-monitoring paths.🛠 Changes Made
values.yaml— addedpipelines.storage.s3.{bucket,accessKey,secretKey}underpipelines:, all defaulting to SeaweedFS values (mlrun/seaweed/seaweed123); updatedstorage.*comment block to clarify it is scopedto MLRun and Jupyter only
templates/_helpers.tpl— added three new helpersmlrun-ce.pipelines.s3.{bucket,accessKey,secretKey}that read frompipelines.storage.s3.*directly (no fallback coupling); fixedmlrun-ce.artifactPath,mlrun-ce.featureStore.dataPrefix, and all threemlrun-ce.model-endpoint.monitoring.*helpers to resolve bucket viacoalesce global.infrastructure.aws.bucketName storage.s3.bucket "mlrun"sostorage.s3.bucketis the effective source for MLRun pathstemplates/pipelines/configmaps/pipeline-install-config.yaml—bucketNamenow usesmlrun-ce.pipelines.s3.bucketinstead ofmlrun-ce.s3.buckettemplates/pipelines/secrets/mlpipeline-seaweedfs-artifact.yaml—accesskey/secretkeynow usemlrun-ce.pipelines.s3.{accessKey,secretKey}instead of the sharedmlrun-ce.s3.*helpersChart.yaml— version bumped0.11.0-rc.36→0.11.0-rc.37README.md— version matrix updated to0.11.0-rc.37✅ Checklist t
charts/mlrun-ce/Chart.yaml.prerequisites.
🧪 Testing
make helm-lintpasses (✔︎ mlrun-ce => version: "0.11.0-rc.37")helm templateverified for all three use cases:bucketName: "mlrun", accesskey =seaweed, secretkey =seaweed123for Pipelines;MLRUN_ARTIFACT_PATH: s3://mlrun/...for MLRunstorage.s3.*to AWS values leavespipelines.storage.s3.*unchanged on SeaweedFS🔗 References
🚨 Breaking Changes?
Yes (explain below)
No
Non-default
storage.s3.*users with Pipelines enabled: any user who previously customizedstorage.s3.accessKey,storage.s3.secretKey, orstorage.s3.bucketexpecting Pipelines to inherit those values must now also set the correspondingpipelines.storage.s3.*keys — Pipelines no longer read fromstorage.s3.*.global.infrastructure.aws.bucketNameusers: MLRun artifact paths previously fell back to the hardcoded string"mlrun"whenglobal.infrastructure.aws.bucketNamewas null; they now fall back tostorage.s3.bucketinstead. Users who had
global.infrastructure.aws.bucketName: ~andstorage.s3.bucketset to a non-"mlrun"value will see their MLRun artifact paths updated automatically — which is the correct behavior but is a change frombefore.
🔍 Additional Notes
global.infrastructure.aws.bucketNamefield is still honored viacoalescefor backwards compatibility with users who set it explicitly, butstorage.s3.bucketis now the recommended single source of truth for the MLRunartifact bucket.