MERGE ALL EARLIER PRs FIRST -- chore: bump dlio-benchmark to DLIO #39; version 3.0.25 -> 3.0.26#582
Merged
Merged
Conversation
DLIO PR #39 (merged f16fe43) fixes #567 — the _LocalFSIterableMixin O_DIRECT gate now triggers on uri_scheme=direct (canonical signal — matches direct_fs validation, which requires storage_library=s3dlio), in addition to the legacy storage_library= direct knob. Net effect for mlpstorage: --o-direct for local NPZ / NPY / JPEG workloads (UNet3D, ResNet, ...) now reaches the s3dlio O_DIRECT engine instead of crashing buffered open() with a direct:// URI in the warmup batch. uv.lock regenerated via `uv lock --upgrade-package dlio-benchmark` (same 108 packages, just the dlio-benchmark source SHA moves).
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
idevasena
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
dlio-benchmarkpin to pick up DLIO PR #39 (mergedf16fe43), which resolves #567, and roll the project version 3.0.25 → 3.0.26.252a54b1→f16fe43f. The fix in Single host reportgen not working? #39 broadens the_LocalFSIterableMixinO_DIRECT gate so it triggers on eitherstorage_options.uri_scheme == "direct"(canonical signal — whatdirect_fsvalidation produces) or the legacystorage_options.storage_library == "direct". Before the fix the two halves of DLIO required differentstorage_libraryvalues and--o-directfor local NPZ / NPY / JPEG always crashed in the warmup batch withFileNotFoundError: 'direct:///mnt/…/foo.npz'.--o-directfor UNet3D / ResNet / any local NPZ-NPY-JPEG workload now reaches the s3dlio O_DIRECT engine instead of feedingdirect://URIs to plainopen().uv.lock: regenerated viauv lock --upgrade-package dlio-benchmark. Same 108 packages resolve; only thedlio-benchmarksource SHA moves.pyproject.toml:131-148updated with a new line for DLIO Single host reportgen not working? #39 / storage --o-direct / storage_type=direct_fs crashes on local NPZ/NPY/JPEG — storage_library sentinel disagreement between config validation ("s3dlio") and the iterable reader ("direct") #567 (most-recent-first ordering).Test plan
uv run pytest tests/unit -q→ 2290 passed. No regressions.test_version_matches_pyprojectandtest_dist_name_matches_pyprojectpass at the new version.uv lockresolves cleanly with no other dependency churn.mlcommons/storage#567reproducer (mlpstorage … training unet3d run file --o-direct …) should now train past warmup. Worth confirming on the lab cluster before tagging a release.Closes / fixes (downstream)
Notes
main(currently includes the recent CAP-01 capacity gate fails for training/checkpointing inobject(S3) mode —statvfsruns on thes3://URI #568 CAP-01 object-mode fix).mainregardless of merge order.