KVCache: Disable pass/fail printing#545
Merged
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
FileSystemGuy
approved these changes
Jun 26, 2026
Contributor
|
Curtis,
In order for the most recent MLP-Storage PR’s to work, we need to merge in the DLIO repo change for PR #38
mlcommons/DLIO_local_changes#38
fix(#538): wire StorageType.DIRECT_FS for --o-direct local O_DIRECT I/O by russfellows · Pull Request #38 · mlcommons/DLIO_local_changes
github.com
… On Jun 26, 2026, at 12:10 PM, Curtis Anderson ***@***.***> wrote:
Merged #545 <#545> into main.
—
Reply to this email directly, view it on GitHub <#545?email_source=notifications&email_token=AF64UJ4PZ5KPINZKOUG276L5B24BFA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTENZSGU4DEMRQHA3DFJTSMVQXG33OWBZGK5TJMV3V64TFOF2WK43UMVSKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#event-27258220862>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF64UJ24RJ4YYULZLM4NLC35B24BFAVCNFSNUABFKJSXA33TNF2G64TZHM2DKOJXGYZTMMBTHNEXG43VMU5TINZVGQYDMNBTGA4KC5QC>.
You are receiving this because your review was requested.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disables the printing of PASS/FAIL results by the KV cache benchmark, as these are not used in the MLPerf 3.0 Benchmark, and this was causing confusion for submitters.