Repository navigation
build(deps): Migrate from npm to pnpm and bump deps - #1465
Conversation
There was a problem hiding this comment.
The build fail : https://github.com/mlco2/codecarbon/actions/runs/40268538553
benoit-cty
left a comment
There was a problem hiding this comment.
Switch to npm on Node 24 and upgrade dependencies
CI and the deployment install with npm ci --include=dev, but local
upgrades went through pnpm, so package-lock.json drifted from
package.json and npm ci failed. Regenerate the lockfile with npm, drop
the pnpm packageManager pin, require Node >=24 and move @types/node to
24 (vitest 5 peer). The Dockerfile used pnpm and a lockfile that isn't
tracked; it now runs the same npm commands as the deployment.
Take the pending major upgrades along with it:
- recharts 3: retype the chart tooltip/legend content props, read the
scatter click's run id from its payload, and give the chart container
a size in tests, since recharts 3 renders nothing at 0x0. - zod 4: ZodError.errors is now .issues.
- eslint 10: declare @eslint/js and globals, which it no longer bundles;
bump eslint-config-prettier to 10.
README and the agent instructions now document npm.
|
Following discussion with @SaboniAmine : Make pnpm the only package manager:
pnpm is kept for its supply-chain defaults, now stated in The Clever Cloud frontend app needs CC_NODE_BUILD_TOOL=pnpm and |
Bumps the npm_and_yarn group with 1 update in the /webapp directory: [zod](https://github.com/colinhacks/zod). Updates `zod` from 3.25.76 to 4.6.7 - [Release notes](https://github.com/colinhacks/zod/releases) - [Commits](colinhacks/zod@v3.25.76...v4.6.7) --- updated-dependencies: - dependency-name: zod dependency-version: 4.6.7 dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
CI and the deployment install with `npm ci --include=dev`, but local upgrades went through pnpm, so package-lock.json drifted from package.json and `npm ci` failed. Regenerate the lockfile with npm, drop the pnpm packageManager pin, require Node >=24 and move @types/node to 24 (vitest 5 peer). The Dockerfile used pnpm and a lockfile that isn't tracked; it now runs the same npm commands as the deployment. Take the pending major upgrades along with it: - recharts 3: retype the chart tooltip/legend content props, read the scatter click's run id from its payload, and give the chart container a size in tests, since recharts 3 renders nothing at 0x0. - zod 4: ZodError.errors is now .issues. - eslint 10: declare @eslint/js and globals, which it no longer bundles; bump eslint-config-prettier to 10. README, AGENTS.md and the agent instructions now document npm.
b5e97be to
bc67a63
Compare
Bumps the npm_and_yarn group with 1 update in the /webapp directory: zod.
Updates
zodfrom 3.25.76 to 4.6.7Release notes
Sourced from zod's releases.
... (truncated)
Commits
b500a2e4.6.79c21983ci: stage at verbose so a failed OIDC token exchange says why529f78d4.6.6a0ebf97fix(v4): check array, set and map size bounds before parsing elements (#6652)a2ba4a6fix(types): declare record output and input as members, not base type argumen...c42596brelease: hold the run on the release-approval environment until the staged ve...bacad51docs: square the Code for Japan logo to match the other bronze tiles8fb2fafdocs: crop the Code for Japan logo and list it first in bronzeb2ef983docs: add Code for Japan to bronze sponsors74304cerelease: stage npm versions instead of publishing them (#6622)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for zod since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsYou can disable automated security fix PRs for this repo from the Security Alerts page.