-
-
Notifications
You must be signed in to change notification settings - Fork 242
Add Nordic region emission factors and update emissions logic #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Nordic region emission factors and update emissions logic #1039
Conversation
- Created nordic_emissions.json with static emission factors (gCO2eq/kWh) for Nordic regions: SE1-4, NO1-5, FI - Updated emissions.py to check for Nordic regions and load static factors from the new JSON file - Sweden/Norway regions use 18 gCO2eq/kWh, Finland uses 72 gCO2eq/kWh based on ENTSO-E data
|
Hello, Can you describe in the code how to proceed to update these values next year ? The best way is to provide a script. If it's too difficult, an URL to the data could be fine. Also, can you fix the linting of the code ? |
|
Hey @benoit-cty, thanks for taking a look! So for the documentation - I'm thinking I'll add some detailed comments right in the code explaining where these numbers come from. The values are based on ENTSO-E data: Sweden/Norway (SE1-4, NO1-5): 18 gCO2eq/kWh - this is based on the Nordic grid average which sits around 60 gCO2eq/kWh. Sweden's specifically around 19 gCO2/kWh from 2023 data. Finland: 72 gCO2eq/kWh - got this from Fingrid's real-time estimates which show it's in the 63-73 range. I'll drop in links to:
For the linting stuff - yeah I see the pre-commit check is waiting for approval. Once you approve it I can see what breaks and fix it. Or I can just run pre-commit locally right now if that's easier? Let me know what you prefer! |
- Added detailed comments explaining data sources (ENTSO-E, Fingrid) - Included update procedure for annual maintenance - Documented emission values: 18 gCO2eq/kWh (SE/NO), 72 gCO2eq/kWh (FI) - Added direct links to data sources for future updates
|
Done! I just pushed the documentation in commit 2ce226a. Added detailed comments in the code with:
For the linting - I'll run pre-commit locally now and push the fixes in a sec. |
|
Just ran pre-commit locally - all checks passed! isort, black, flake8, and autoflake all came back clean. The code's good to go on the linting side. |
|
Hello, thanks for your contribution!
|

Description
Please explain the changes you made here.
Related Issue
Please link to the issue this PR resolves: [issue #]
Motivation and Context
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.