audit: revalidate cross-framework comparisons - #79
Draft
stefan-jansen wants to merge 78 commits into
Draft
Conversation
Centralize immutable framework versions, artifact identities, environment mappings, and scenario membership. Add a validated cross-repository claim inventory for the library, current chapter notebooks, and publication drafts. Closes ml4t/backtest-dev#2
Serialize both engine outputs, structured exact checks, runtimes, record counts, framework and Python identity, and content-derived provenance. Validate full candidates, reject stale or dirty evidence, and promote accepted results atomically only after the complete matrix passes. Closes ml4t/backtest-dev#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Revalidate the current comparison suite against VectorBT OSS and Pro, Backtrader, Zipline Reloaded, and LEAN. Correct adapters, profiles, evidence, benchmarks, and publication-facing claims, then retain a clean rerun.
Coordination milestone: audit-2026-08
Current result
1e-8. Account monetary values use a $0.01 round-half-even quantum. The largest retained raw monetary gap is $0.00000015, or 0.000015 cents.The separate synthetic convention matrix has 66 required passes and two declared unsupported rows. The corrected 250-asset, 5,040-session stress workload passes for all five framework profiles. These remain secondary diagnostic and scale evidence, not the primary realistic-strategy result.
Material correction
The VectorBT stress adapters previously omitted
call_seq, so the native engine used column order while the documented ML4T profile used automatic sequencing. The first divergence occurred at fill 58,324. The corrected adapters passcall_seq="auto"; regression tests cover the setting, and the clean stress rerun passes all five rows.Retained evidence
validation/REAL_STRATEGY_RESULTS.jsonvalidation/REAL_STRATEGY_PERFORMANCE.jsonvalidation/CORRECTNESS_RESULTS.jsonvalidation/LARGE_SCALE_RESULTS.jsonvalidation/METHODOLOGY.mdPublication checks reject stale or incomplete evidence by validating engine and adapter digests, the full required and unsupported matrix, negative controls, comparison surfaces, and performance linkage.
Verification
c4b1a6b3fc4422d50840cde41ffd5d5990f2f17a: 12/12 required pairs pass, 8 unsupporteduv run ruff check src tests validation: passeduv run ruff format --check src tests validation: passeduv run ty check: passeduv run pytest: 2,124 passed, 14 skipped, 87.14% coveragepre-commit run --all-files: passed