Skip to content

Compute contiguity from the actual occupied data#3475

Open
sofinvalery wants to merge 1 commit intoml-explore:mainfrom
sofinvalery:as-strided
Open

Compute contiguity from the actual occupied data#3475
sofinvalery wants to merge 1 commit intoml-explore:mainfrom
sofinvalery:as-strided

Conversation

@sofinvalery
Copy link
Copy Markdown

Proposed changes

Compute AsStrided contiguity from the actual occupied data instead of only checking row or column contiguous layouts.

This allows dense non-row/column views, such as dense stride permutations, to be marked contiguous while keeping overlapping, gapped, broadcast-style, and negative-stride views conservative. It also computes a more accurate data_size for as_strided views.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

Copy link
Copy Markdown
Collaborator

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm not sure about the negative stride part. @angeloskath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants