Open
Conversation
efb087e to
9e2acbb
Compare
9e2acbb to
40bcaea
Compare
Drop the intermediate OBJECT library target and fold gguflib sources directly into mlx via target_sources, and propagate the include path through BUILD_INTERFACE directly on the mlx and tests targets.
25d28a5 to
9ff0d34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3358.
Summary
ndimexceedsGGUF_TENSOR_MAX_DIMbefore converting tensor dimensions to an MLX shape, including both values in the error message.mlxviatarget_sourcesso downstream static-link consumers don't hit unresolved symbols, and expose gguflib headers only to MLX sources and the GGUF-specific test viaBUILD_INTERFACE.Tests