Skip to content

fix: handle missing related asset fields in assetsToDf function #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jondricek merged 1 commit into from
Apr 27, 2026
+34 −3
Merged

fix: handle missing related asset fields in assetsToDf function #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions mitreattack/attackToExcel/stixToDf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,9 +753,40 @@ def assetsToDf(src):
related_assets_descriptions = []

for related_asset in asset["x_mitre_related_assets"]:
related_assets.append(related_asset["name"])
related_assets_sectors.append(", ".join(related_asset["related_asset_sectors"]))
related_assets_descriptions.append(related_asset["description"])
asset_name = row.get("name", "<unnamed asset>")
asset_id = row.get("ID", "<missing ATT&CK ID>")
asset_stix_id = row.get("STIX ID", "<missing STIX ID>")
related_asset_name = related_asset.get("name", "<unnamed related asset>")

if "name" in related_asset:
related_assets.append(related_asset["name"])
else:
logger.error(
f"Missing name for related asset '{related_asset_name}' on asset '{asset_name}' "
f"({asset_id}, {asset_stix_id}). Leaving related assets blank for this related asset "
"and continuing export."
)
related_assets.append("")

if "related_asset_sectors" in related_asset:
related_assets_sectors.append(", ".join(related_asset["related_asset_sectors"]))
else:
logger.error(
f"Missing related_asset_sectors for related asset '{related_asset_name}' on asset "
f"'{asset_name}' ({asset_id}, {asset_stix_id}). Leaving related assets sectors blank "
"for this related asset and continuing export."
)
related_assets_sectors.append("")

if "description" in related_asset:
related_assets_descriptions.append(related_asset["description"])
else:
logger.error(
f"Missing description for related asset '{related_asset_name}' on asset '{asset_name}' "
f"({asset_id}, {asset_stix_id}). Leaving related assets description blank for this "
"related asset and continuing export."
)
related_assets_descriptions.append("")

row["related assets"] = "; ".join(related_assets)
row["related assets sectors"] = "; ".join(related_assets_sectors)
Expand Down