Skip to content

chore(ui-react): keep the BRANDING comment with the key it explains #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mosoriob merged 1 commit into from
Sep 1, 2026
Merged

chore(ui-react): keep the BRANDING comment with the key it explains #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions charts/mint/templates/ui-react-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,13 @@ data:
AUTH_CALLBACK_ORIGIN: {{ . | quote }}
{{- end }}

{{- with $cfg.branding }}
# Presentation. Which co-branding chrome the application renders -- the
# branding strip, the footer and the dark header. It names a preset held in
# the image, so the logo files, link targets and alt text stay under code
# review rather than living in these values. Left empty, the image's own
# default applies, which is unbranded. Set it only on a deployment entitled
# to show that institution's marks.
{{- with $cfg.branding }}
# review rather than living in these values. Set only on a deployment
# entitled to show that institution's marks; left empty the key is omitted
# and the image's own default applies, which is unbranded.
BRANDING: {{ . | quote }}
{{- end }}

Expand Down
1 change: 1 addition & 0 deletions charts/mint/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ components:
# -- Origin to use for the OAuth2 callback. Leave empty to use the
# deployment's own origin, which is correct for a real cluster host.
auth_callback_origin: ""
# Presentation.
# -- Co-branding chrome the React UI renders: the branding strip, the
# footer and the dark header. `tacc` shows the TACC and UT Austin marks;
# `none` shows no institutional chrome. Names a preset held in the image,
Expand Down
Loading