feat(ui-react): forward BRANDING to the React UI ConfigMap - #114
Merged
Conversation
The image reads a BRANDING key at startup and renders the co-branding chrome named by it. The chart built the ui_react ConfigMap from a fixed list of keys and had no escape hatch, so no values file could send the new key. The image default, unbranded, was the only reachable setting. Follow EXECUTION_ENGINE: the value is per-component, under components.ui_react.config. WELCOME_MESSAGE reads a top-level key it shares with the legacy UI; that UI is retired, so a shared key buys nothing here. Omit the key when the value is empty, as the other optional keys do, so an unset value falls back to the image default instead of blanking it. Refs mintproject/monorepo#207
Carries the BRANDING key for the React UI. No other change since 9.0.0-beta.10. A deployment cannot set BRANDING until it installs this version, so the key needs a published chart, not only a merged template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries
BRANDINGfrom a values file to theui_reactpod.Why
The image reads
BRANDINGat startup and renders the co-branding chrome it names(mintproject/monorepo#206). The chart built the
ui_reactConfigMap from a fixed list ofkeys and had no
extraEnvescape hatch, so no values file could send the key. The imagedefault, unbranded, was the only reachable setting.
What
templates/ui-react-config.yaml— emitBRANDINGfrom$cfg.branding, omitted when empty.values.yaml—components.ui_react.config.branding: "".README.md— the new row.9.0.0-beta.11. A deployment cannot set the key until it installs a publishedchart, so the release is part of the change.
Decision
Per-component,
components.ui_react.config.branding, followingEXECUTION_ENGINE.WELCOME_MESSAGEreads a top-level key it shares with the legacy UI. That UI is retired(mintproject/monorepo#81), so a shared key buys nothing.
Checks
helm templatewith the key set emitsBRANDING: "tacc". Unset, and set to the emptystring, the key is absent.
helm lintpasses.Refs mintproject/monorepo#207