feat(ui): disable the legacy LitElement UI by default - #111
Merged
Conversation
ui_react is the maintained frontend. The legacy `ui` component stays in the chart, but a consumer now opts in rather than out. Document the tag constraint that made this urgent. beta.7 moved mint-ui-lit to GHCR, but only `latest` and `main` were pushed there. Every per-commit SHA tag lives only on Docker Hub, so an existing SHA pin against the GHCR repository fails to pull. The dev cluster hit exactly that during the 9.0.0-beta.8 upgrade: ImagePullBackOff on mint-ui while the old ReplicaSet kept serving. Package as 9.0.0-beta.9. Note: ui_react is also disabled by default, because enabling it requires an OAuth2 client_id and the chart refuses to render without one. A bare install therefore ships no frontend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ui_reactis the maintained frontend. The legacyuicomponent stays in the chart, but a consumer now opts in rather than out.Packaged as
9.0.0-beta.9.The tag constraint that made this urgent
#109 moved
mint-ui-litfrom Docker Hub to GHCR. Onlylatestandmainwere ever pushed there. Every per-commit SHA tag lives only on Docker Hub:The dev cluster hit exactly this during the
9.0.0-beta.8upgrade:ImagePullBackOffonmint-uiwhile the old ReplicaSet kept serving, so the UI looked alive andhelm upgrade --waitfailed naming a different resource.The
components.ui.image.tagdoc comment now records the constraint. This PR does not backfill the SHA tags in GHCR — that is a separate decision, and it only matters for consumers who both enable the component and pin a SHA.Please read before merging
A bare install now ships no frontend.
ui_reactis also disabled by default, because enabling it requirescomponents.ui_react.config.client_idand the chart hard-fails to render without one. So with this change, neither UI renders out of the box.That is a coherent position — a deployment must choose and configure its frontend — but it is a real behaviour change, so it should be a deliberate one.
Check
dynamobefore this ships to TACC. If the production values rely oncomponents.ui.enableddefaulting totrue, this silently removes the legacy UI on the next chart bump.mintproject/monorepo#81still tracks removing Lit from TACC, and it is open.Verification
uiabsent, nomint-ui-litimage.--set components.ui.enabled=true: rendersghcr.io/mintproject/mint-ui-lit:latestas before.helm lint: 0 failed.deployedand theImagePullBackOffpod is gone.README.mdregenerated with helm-docs 1.14.2.