v2: bump module path and remove altsrc - #13
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR removes the ChangesAltsrc removal
Module and test-runner migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🟡 Moderate · up to The module path migration and altsrc removal leave the default test harness referencing the old module and a removed package, which can break the normal test/build path. Update the harness before merging. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bump the module path to github.com/minio/cli/v2 and delete the altsrc package, which provided TOML/YAML-backed flag input sources. Removing it drops the BurntSushi/toml, yaml.v2 and urfave/cli.v1 dependencies, leaving the module with no external requirements. Also drops the altsrc code generator from generate-flag-types, which is now only used for the cli package. Update the CI configuration accordingly: runtests now defaults CLI_PACKAGE_NAME to the v2 module path and no longer iterates over the altsrc subpackage, and AppVeyor clones into the matching GOPATH location.
We do not use altsrc in any repo, and it complicates some code changes. appveyor.yml is unused and outdated CI. Also version bump to signify breaking changes ahead.
Summary by CodeRabbit
Breaking Changes
altsrcAPIs or configuration loaders must migrate before upgrading.