Skip to content

v2: bump module path and remove altsrc - #13

Merged
taran-p merged 1 commit into
minio:masterfrom
taran-p:feat/v2-base
Aug 31, 2026
Merged

v2: bump module path and remove altsrc#13
taran-p merged 1 commit into
minio:masterfrom
taran-p:feat/v2-base

Conversation

@taran-p

@taran-p taran-p commented Aug 29, 2026

Copy link
Copy Markdown

We do not use altsrc in any repo, and it complicates some code changes. appveyor.yml is unused and outdated CI. Also version bump to signify breaking changes ahead.

Summary by CodeRabbit

Breaking Changes

  • Removed alternate configuration sources, including TOML, YAML, and map-based inputs.
  • Removed APIs for applying external input values to command-line flags.
  • Removed legacy compatibility integrations and related configuration-loading functionality.
  • Updated the module path to version 2.
  • Existing applications using the removed altsrc APIs or configuration loaders must migrate before upgrading.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 290ca0b4-93aa-436f-8887-d7230ff57f72

📥 Commits

Reviewing files that changed from the base of the PR and between b3bcf17 and 2a119b3.

📒 Files selected for processing (2)
  • appveyor.yml
  • runtests
💤 Files with no reviewable changes (1)
  • appveyor.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR removes the altsrc package, its input-source implementations, generated flag wrappers, and related tests. It also removes altsrc generator support, updates the module path to github.com/minio/cli/v2, removes altsrc dependencies, and stops altsrc coverage testing.

Changes

Altsrc removal

Layer / File(s) Summary
Remove altsrc implementations and validation
altsrc/*
The PR deletes alternate input-source interfaces, map, YAML, and TOML loaders, flag integration methods, generated wrappers, and related tests.
Remove altsrc generation support
generate-flag-types
The generator no longer emits altsrc flag types. Its package choices now include only cli.

Module and test-runner migration

Layer / File(s) Summary
Update module and test configuration
go.mod, runtests
The module path changes to github.com/minio/cli/v2. The altsrc-related dependencies are removed. The test runner uses the new module path and excludes altsrc coverage.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🟡 Moderate · up to 2a119

The module path migration and altsrc removal leave the default test harness referencing the old module and a removed package, which can break the normal test/build path. Update the harness before merging.

Poem

A rabbit reviews the flags at dawn
The old altsrc paths are gone
The generator now emits cli
The module carries v2
Tests follow the new path along

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the two primary changes: updating the module path to v2 and removing the altsrc package.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as outdated.

Bump the module path to github.com/minio/cli/v2 and delete the altsrc
package, which provided TOML/YAML-backed flag input sources. Removing it
drops the BurntSushi/toml, yaml.v2 and urfave/cli.v1 dependencies, leaving
the module with no external requirements.

Also drops the altsrc code generator from generate-flag-types, which is now
only used for the cli package.

Update the CI configuration accordingly: runtests now defaults
CLI_PACKAGE_NAME to the v2 module path and no longer iterates over the
altsrc subpackage, and AppVeyor clones into the matching GOPATH location.
@taran-p
taran-p merged commit 13f7a53 into minio:master Aug 31, 2026
2 checks passed
@taran-p
taran-p deleted the feat/v2-base branch August 31, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant