-
-
Notifications
You must be signed in to change notification settings - Fork 431
Render byte[] template placeholders as images #1018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
EnzoSam
wants to merge
7
commits into
mini-software:master
Choose a base branch
from
EnzoSam:feature/template-image-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
50c39a2
Render byte[] values as images in templates
EnzoSam 20d2a99
docs: document template image support
EnzoSam 8456f88
Size template images to the row height
EnzoSam c0d8cc3
Avoid duplicate picture ids when merging template drawings
EnzoSam 9d2cbeb
Keep image parts and relationships unique per anchor
EnzoSam cc2b5e2
Release template image bytes once they are captured
EnzoSam 1c12945
Fix template image docs wording and IdSuffix comment
EnzoSam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Fix the integer overflow in the TIFF IFD bounds check.
ifdOffsetcomes straight from the image header. IfifdOffsetis close toint.MaxValue,ifdOffset + 2wraps to a negative value. TheifdOffset + 2 > bytes.Lengthcheck then passes.ReadUInt16(bytes, ifdOffset, ...)then throwsIndexOutOfRangeException. The same wraparound can happen inifdOffset + 2 + (i * 12)at Line 176.GetImageMarkercallsGetImageSizefor every recognizedbyte[]value. One crafted TIFF value in the template data therefore aborts the wholeFillTemplatecall. The contract says the method returnsnullwhen the header is truncated, so it should not throw.🐛 Proposed fix
var littleEndian = bytes[0] == 'I'; var ifdOffset = ReadInt32(bytes, 4, littleEndian); - if (ifdOffset < 8 || ifdOffset + 2 > bytes.Length) + if (ifdOffset < 8 || ifdOffset > bytes.Length - 2) return null;Also bound the entry offset without an overflow:
Both changes are overflow-safe: once
ifdOffset <= bytes.Length - 2,entryOffsetstays belowbytes.Length + 12 * 65535, which fits inint.🤖 Prompt for AI Agents