Bound synthesized rows in v1 OpenXml queries - #1017
Merged
michelebastione merged 2 commits intoSep 26, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Member
Author
|
@michelebastione good day, this's critical issue, could you please to review? |
- Added check to `ReadCellAndSetColumnIndexAsync` to throw an exception when the column number exceeds the Excel column limit - Included empty row tags in the calculation of synthesized cells count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports the OpenXml query hardening from #1016 to
v1.x-maintenance.XFD1048576limits before filling missing rowsQueryRangeMaxSynthesizedCellsbudget, defaulting to 100,000, to prevent sparse worksheets from amplifying into excessive allocationsSecurity impact
This prevents a crafted worksheet row index or sparse worksheet dimension from causing MiniExcel to synthesize an excessive number of empty row objects and cells during
Queryenumeration.Testing
375 tests passed.