Skip to content

fix(argocd-pr-env-deploy): turn the staff console off when no Deploys line selects it (ENG-3872) - #75

Merged
mindsdb-devops merged 2 commits into
mainfrom
fix/eng-3872-stafftools-deploys-off
Nov 1, 2026
Merged

mindsdb-devops merged 2 commits into
mainfrom
fix/eng-3872-stafftools-deploys-off

Conversation

@lucas-koontz

@lucas-koontz lucas-koontz commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

User story

As an engineer, I want removing a Deploys: mindshub_stafftools#... line to turn the staff console off in my PR env, so that the console runs only while a PR selects it.

Why this matters

argocd app set only adds parameters. Removing the line left the console running until someone unset its parameters by hand.

What should happen

When the deploy sets no stafftools revision, the deploy step unsets tags.mindshub_stafftools and revisions.mindshub_stafftools on the parent. A mindshub_stafftools anchor or a Deploys: mindshub_stafftools#... line sets that revision, so the step reads the links the deploy already resolved rather than parsing the body a second time. It keeps every other parameter, and it does nothing when neither is set.

Test plan

  • Removing the line turns the console off: the action's shell, from the anchor's parameters through the Deploys: link loop with GitHub stubbed, run against a fake argocd, unsets exactly those two parameters. Passed under bash 5.2, as on the runner.
  • A selected console stays on: a stafftools anchor and each Deploys: form (#N, #staging, #main, with or without the org), resolved by the action's own link loop, skip the unset. Other repos' links and look-alike names don't select it. Passed.
  • Other parameters stay: a parent with other parameters loses only the two staff console ones, and a parent with neither sees no unset call. Passed.
  • The unset runs after the parent is read and before app set, and not before the parent exists. Passed.

@lucas-koontz
lucas-koontz requested a review from a team as a code owner November 1, 2026 09:39
@mindsdb-devops
mindsdb-devops merged commit 010a850 into main Nov 1, 2026
6 checks passed
@mindsdb-devops
mindsdb-devops deleted the fix/eng-3872-stafftools-deploys-off branch November 1, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants