Repository navigation
fix(pr-envs): list the SAM stack in the close reminder and retry blocked deploys by re-run (ENG-3872) - #74
Merged
Conversation
…ked deploys by re-run (ENG-3872)
mindsdb-devops
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User story
As the engineer who runs a customer PR environment
I want the close reminder to list everything the env leaves behind, and a blocked deploy to say how to retry without losing the env
So that nothing keeps running by accident, and a retry never costs the env its database
Why this matters
When a customer PR closes, the reminder lists its files, Cowork workspaces and Postgres volume, but not its SAM stack. The stack can outlive the PR, so it keeps running and holding the env's data until someone notices. When a
Deploys:link conflicts, the blocked-deploy comment tells the author to retry by toggling thedeploylabel. Removing that label deletes the env, so the suggested retry recreates it on an empty database.Test plan
anton-services-pr-<slug>-<N>and ends with "if it still exists".printfthrough bash and checks both steps.deploy, and warns that removing it deletes the env: same test.test_reminder_asks_for_nothing_the_backup_vault_refusespins it; 252 tests pass.