Repository navigation
Customer PR envs: stale cron, close reminder, #main links, comment hosts, label guard - #73
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…abel guard Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mindsdb-devops
previously approved these changes
Oct 30, 2026
…els API call - argocd-pr-env-deploy: `repo#staging`/`repo#main` run the ECR existence check before pinning (cowork publishes no `production` tag); revision-only repos get the chart branch alone for both forms; `argocd-envs#staging|main` moves the parent revision instead of failing as a missing PR; the PR fetch guard also covers a non-JSON body. - pr-env-comment: customer host comes from the event payload's labels, not a second API call inside the redirect group. - prune: scan every closed PR (--paginate) and remind only PRs that carried `deploy` as well as `customer:`; the reminder points at argocd-envs `filesBucket` instead of naming the bucket. - tests: deploy-label filter, pagination flag, comments-read failure path. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mindsdb-devops
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stale-deploy-label cron no longer strips the deploy label from PRs carrying a
customer:label.prune-pr-environments posts one reminder comment when a PR that carried both
deployand acustomer:label closes. Every closed PR is scanned (paginated, about 52 pages per hourly run across the anchor repos), so a PR missed during an outage is still reminded once. The reminder points at argocd-envsfilesBucketrather than naming the bucket.pr-env-comment shows the branded host for customer envs, read from the event payload's labels.
argocd-pr-env-deploy accepts
Deploys: repo#main: image tagproductionand git revisionmain(revision only for mindshub_services). Both#stagingand#mainlinks run the ECR existence check before pinning, so a repo without that tag (cowork has noproduction) fails fast instead of waiting out the timeout.Deploys: argocd-envs#staging|mainmoves the parent chart revision.In argocd-pr-env-deploy, anton's ECR existence check uses the
minds-anton-scratchpadrepository.argocd-pr-env-deploy refuses to deploy, with a PR comment, when the PR's
customer:label differs from the hostBase the existing parent Application was created with.🤖 Generated with Claude Code