Repository navigation
♻️ remove need for un-needed fixture in unit tests - #471
Merged
Merged
Conversation
sebastianMindee
requested review from
ianardee
and
a balanced review from Copilot
October 14, 2026 13:04
ianardee
approved these changes
Oct 14, 2026
There was a problem hiding this comment.
🟢 Approval recommended
Unit tests exclude integration tests and no longer require the removed environment variables.
0 open findings
What changed in this PR
Removes unnecessary secret-backed fixtures from isolated V2 client unit tests.
Changes:
- Replaces model-ID fixtures with local dummy values.
- Removes unused V2 secrets from the unit-test workflow.
| File | Description |
|---|---|
tests/v2/test_client.py |
Makes mocked error tests self-contained. |
.github/workflows/_test-units.yml |
Removes integration-only secrets. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes