Fix release drafter empty changelogs and render stale branch refs#16
Merged
Fix release drafter empty changelogs and render stale branch refs#16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
workflow_dispatchtrigger for manual re-runs when drafts are emptyflow renderto useorigin/<default>instead of local branch ref when creating new branchesWhy
Release drafter was intermittently producing empty changelogs ("No changes") because its GraphQL query for associated pull requests ran before the API had propagated the commit/PR association (~9s after push). Traced through the release-drafter v6 source to confirm the query uses
history(since:)withassociatedPullRequests, which is subject to eventual consistency.Separately,
flow renderwas creating new branches from potentially stale local refs in the bare repo cache. Afterfetch --all, the remote tracking refs (origin/main) are updated but the local branch ref (main) may still point to an old commit.Ref
lib/commits.js—findCommitsWithAssociatedPullRequestsQuery