Fixed idempotency when default user replaced #12 #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This is pending setting up a proper CI env. |
mikolak-net
reviewed
Apr 4, 2020
Owner
mikolak-net
left a comment
mikolak-net
left a comment
There was a problem hiding this comment.
First of all, terribly sorry for taking so long to get around to this.
Looks good, but for one minor thing.
|
|
||
| - name: Verify if replace_user exists | ||
| stat: | ||
| path: "/etc/sudoers.d/{{ raspi_config_replace_user['name'] }}" |
Owner
There was a problem hiding this comment.
Just a small remark - shouldn't this also include the pseudo-priority prefix, in line with how the directory is organized by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve #12
Hope it will also help with #10