Disable gethostbyname and getaddrinfo too.#64
Disable gethostbyname and getaddrinfo too.#64shaleh wants to merge 2 commits intomiketheman:mainfrom
Conversation
When socket is disabled, disable these address lookups as well.
|
Thanks @shaleh ! Looks interesting. Please take a look at the failure and see if you can resolve? I'd also appreciate a new test case for each of the specific sockets being added, since I think the logic will apply to all sockets equally, so if one is blocked, all would be blocked, so the tests should explicitly ensure that if something is calling |
|
@miketheman no problem. I did not put a ton of time in case the implementation was not the desired approach. Happy to ensure tests pass and are as desired. |
|
I am more accustomed to a tox based test world so I do not need to install the tooling in my own environment. I did not see a clean way to test this project as is. |
|
Fun, works on Linux (where I experimented) and fails everywhere else. |
|
Code Climate has analyzed commit 69321a6 and detected 0 issues on this pull request. View more on Code Climate. |
When socket is disabled, disable these address lookups as well.
Addresses #43