Skip to content

firecracker: Set --enable-pci option by default when available #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

firecracker: Set --enable-pci option by default when available #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/runners/firecracker.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,15 +86,15 @@ in {
then throw "hotpluggedMem not implemented for Firecracker"
else if credentialFiles != {}
then throw "credentialFiles are not implemented for Firecracker"
else lib.escapeShellArgs [
else lib.escapeShellArgs ([
"${pkgs.firecracker}/bin/firecracker"
"--config-file" configFile
"--api-sock" (
if socket != null
then socket
else throw "Firecracker must be configured with an API socket (option microvm.socket)!"
)
];
] ++ lib.optional (lib.versionAtLeast pkgs.firecracker.version "1.13.0") "--enable-pci");

preStart = ''
${preStart}
Expand Down