Skip to content

Weekly Permissions sync 2026-09-18 - #1633

Merged
Jason Johnston (jasonjoh) merged 2 commits into
masterfrom
permissions-update/2026-09-18
Sep 18, 2026
Merged

Jason Johnston (jasonjoh) merged 2 commits into
masterfrom
permissions-update/2026-09-18

Conversation

@marabooy

Copy link
Copy Markdown
Contributor

Weekly Permissions sync 2026-09-18

@marabooy
David (marabooy) requested a review from a team as a code owner September 18, 2026 00:56
Copilot AI lite review requested due to automatic review settings September 18, 2026 00:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Missing permission definitions and placeholder UUIDs must be corrected.

Pull request overview

Synchronizes Teams permission deployment metadata and updates permission ownership groups.

Changes:

  • Adds Channel and Chat call-event deployment records.
  • Reassigns Teams permissions to the new approver group.
File summaries
File Summary Findings
permissions/new/provisioningInfo.json Adds call-event deployment metadata. Add missing permission definitions and replace two placeholder UUIDs with authoritative app-role IDs.
permissions/new/permissions.json Updates Teams permission ownership groups. No issues identified.
Review details

Suppressed comments (3)

permissions/new/provisioningInfo.json:3027

  • These deployment records introduce four permission names that do not exist anywhere in permissions/new/permissions.json (the repository-wide search only finds them here). As a result, consumers that read the permission definitions/path-set catalog cannot resolve or expose these permissions even though provisioning metadata advertises them; add the corresponding definitions (schemes, descriptions, path sets, and owner info) alongside these records.
    "ChannelCallEvents.Read": [
      {
        "id": "96cbc1bf-c88b-4bc4-941a-1ff53ff33b22",
        "scheme": "DelegatedWork",
        "environment": "public",

permissions/new/provisioningInfo.json:3479

  • This UUID is a hand-crafted placeholder pattern (a4f9...8e2b...2b5e...) rather than an authoritative-looking permission ID. Publishing it would make the ChatCallEvents.Read.All deployment metadata point at a nonexistent/mismatched app role; please replace it with the ID from the source permission registration.
        "id": "a4f9c1d7-8e2b-4d3a-9c6f-2b5e7a1f9d84",

permissions/new/provisioningInfo.json:3469

  • This UUID has an obvious hand-crafted placeholder pattern (7d2a...3c1f...9f6c...) unlike the authoritative app-role IDs used by the surrounding deployment records. If this value is published, provisioning will not match the real ChatCallEvents.Read role; please use the ID from the source permission registration instead of a fabricated GUID.
        "id": "7d2a4e6b-3c1f-4a89-b5e2-9f6c1d84a7b3",
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jasonjoh
Jason Johnston (jasonjoh) merged commit 82a6561 into master Sep 18, 2026
4 checks passed
@jasonjoh
Jason Johnston (jasonjoh) deleted the permissions-update/2026-09-18 branch September 18, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants