Weekly Permissions sync 2026-09-18 - #1633
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Missing permission definitions and placeholder UUIDs must be corrected.
Pull request overview
Synchronizes Teams permission deployment metadata and updates permission ownership groups.
Changes:
- Adds Channel and Chat call-event deployment records.
- Reassigns Teams permissions to the new approver group.
File summaries
| File | Summary | Findings |
|---|---|---|
permissions/new/provisioningInfo.json |
Adds call-event deployment metadata. | Add missing permission definitions and replace two placeholder UUIDs with authoritative app-role IDs. |
permissions/new/permissions.json |
Updates Teams permission ownership groups. | No issues identified. |
Review details
Suppressed comments (3)
permissions/new/provisioningInfo.json:3027
- These deployment records introduce four permission names that do not exist anywhere in
permissions/new/permissions.json(the repository-wide search only finds them here). As a result, consumers that read the permission definitions/path-set catalog cannot resolve or expose these permissions even though provisioning metadata advertises them; add the corresponding definitions (schemes, descriptions, path sets, and owner info) alongside these records.
"ChannelCallEvents.Read": [
{
"id": "96cbc1bf-c88b-4bc4-941a-1ff53ff33b22",
"scheme": "DelegatedWork",
"environment": "public",
permissions/new/provisioningInfo.json:3479
- This UUID is a hand-crafted placeholder pattern (
a4f9...8e2b...2b5e...) rather than an authoritative-looking permission ID. Publishing it would make theChatCallEvents.Read.Alldeployment metadata point at a nonexistent/mismatched app role; please replace it with the ID from the source permission registration.
"id": "a4f9c1d7-8e2b-4d3a-9c6f-2b5e7a1f9d84",
permissions/new/provisioningInfo.json:3469
- This UUID has an obvious hand-crafted placeholder pattern (
7d2a...3c1f...9f6c...) unlike the authoritative app-role IDs used by the surrounding deployment records. If this value is published, provisioning will not match the realChatCallEvents.Readrole; please use the ID from the source permission registration instead of a fabricated GUID.
"id": "7d2a4e6b-3c1f-4a89-b5e2-9f6c1d84a7b3",
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Jason Johnston (jasonjoh)
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly Permissions sync 2026-09-18