Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 29, 2025

Updated the README.md to include testing instructions in both sample query workflows, ensuring contributors validate their changes locally before committing.

Changes Made

Main workflow section:

  • Added "Run npm run test to test your changes locally" as step 3 in the numbered workflow

Command line workflow section:

  • Added new "### 5. Test your changes locally" section with instructions to run npm run test
  • Updated subsequent section numbering (6→7, 7→8) to maintain proper sequence

Benefits

This change helps contributors:

  • Catch validation errors early in sample queries (format, structure, GUIDs, etc.)
  • Ensure their changes pass existing tests before creating PRs
  • Reduce back-and-forth in code reviews due to test failures

The existing test infrastructure validates critical aspects like unique GUIDs, proper URL formats, valid JSON in POST bodies, and other sample query requirements.

Fixes #107.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • docs.microsoft.com
    • Triggering command: node scripts/test-initiator.js --no-watch (dns block)
  • learn.microsoft.com
    • Triggering command: node scripts/test-initiator.js --no-watch (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Aug 29, 2025

@jasonjoh 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Co-authored-by: jasonjoh <8966342+jasonjoh@users.noreply.github.com>
Copilot AI changed the title [WIP] Update Devx content Read.me Add npm run test step to README.md workflows for local testing before committing Aug 29, 2025
Copilot AI requested a review from jasonjoh August 29, 2025 16:31
@jasonjoh jasonjoh marked this pull request as ready for review August 29, 2025 16:44
Copilot AI review requested due to automatic review settings August 29, 2025 16:44
@jasonjoh jasonjoh requested a review from a team as a code owner August 29, 2025 16:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds testing instructions to the README.md workflows to encourage contributors to validate their changes locally before committing. The change addresses issue #107 by adding npm run test steps to both the main workflow and command line workflow sections.

  • Added testing step to the main numbered workflow
  • Added new testing section to command line workflow with proper renumbering
  • Maintains workflow sequence by updating subsequent section numbers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jasonjoh jasonjoh merged commit d94d6e3 into dev Sep 2, 2025
6 checks passed
@jasonjoh jasonjoh deleted the copilot/fix-107 branch September 2, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Devx content Read.me

3 participants