Skip to content

Network-25394: Adding test #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SagarSathe merged 10 commits into from
Dec 31, 2025
Merged

Network-25394: Adding test #696

SagarSathe merged 10 commits into from
Dec 31, 2025

Conversation

@sandeepjha000
Copy link
Collaborator

@sandeepjha000 sandeepjha000 commented Dec 11, 2025 •
edited
Loading

Network-25394: Adding test

@sandeepjha000 sandeepjha000 self-assigned this Dec 11, 2025
@sandeepjha000 sandeepjha000 added the ready for review PR is ready for review and merging label Dec 11, 2025
@alexandair
Copy link
Collaborator

alexandair commented Dec 14, 2025

@sandeepjha000
What spec do you use for this test? I don't see the test logic you coded specified in 25394.docx.

/cc @tdetzner @SagarSathe

@alexandair alexandair removed the ready for review PR is ready for review and merging label Dec 15, 2025
@sandeepjha000 sandeepjha000 marked this pull request as draft December 16, 2025 02:00
@sandeepjha000 sandeepjha000 added the question Further information is requested label Dec 17, 2025
@sandeepjha000 sandeepjha000 added ready for review PR is ready for review and merging and removed question Further information is requested labels Dec 30, 2025
@sandeepjha000 sandeepjha000 marked this pull request as ready for review December 30, 2025 10:55
@sandeepjha000 sandeepjha000 changed the title Feature-25394: Quick Access is bound to a Conditional Access policy Network-25394: Adding test Dec 30, 2025
alexandair
alexandair approved these changes Dec 30, 2025
View reviewed changes
Copy link
Collaborator

@alexandair alexandair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarSathe
SagarSathe approved these changes Dec 31, 2025
View reviewed changes
Copy link
Collaborator

@SagarSathe SagarSathe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarSathe SagarSathe merged commit 183ad95 into main Dec 31, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandair alexandair alexandair approved these changes

@SagarSathe SagarSathe SagarSathe approved these changes

@merill merill Awaiting requested review from merill

@tdetzner tdetzner Awaiting requested review from tdetzner

Assignees

@sandeepjha000 sandeepjha000

Labels

ready for review PR is ready for review and merging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sandeepjha000 @alexandair @SagarSathe