Skip to content

Enhance chat question carousel with markdown link support - #333751

Merged
Lee Murray (mrleemurray) merged 1 commit into
mainfrom
mrleemurray/compact-moccasin-roadrunner
Sep 1, 2026
Merged

Enhance chat question carousel with markdown link support#333751
Lee Murray (mrleemurray) merged 1 commit into
mainfrom
mrleemurray/compact-moccasin-roadrunner

Conversation

@mrleemurray

@mrleemurray Lee Murray (mrleemurray) commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This ensures links throughout the chat question carousel use theme-provided colors so they remain legible in themes such as Kimbie Dark.

Screenshot 2026-09-01 at 12.31.46.png

Changes

  • Apply the text link foreground and active foreground tokens to links in every rendered markdown region
  • Cover carousel-level messages, question titles, and detailed question content
  • Add a screenshot fixture demonstrating links across all three regions

Validation

  • 73 question carousel unit tests passed
  • ESLint passed
  • Stylelint passed
  • Component Explorer compiled successfully
  • Verified in the dark fixture that links resolve to the configured theme color

Fixes #333616

Copilot AI balanced review requested due to automatic review settings September 1, 2026 11:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates chat question carousel links to use theme-provided colors across all markdown regions.

Changes:

  • Applies themed link colors to carousel messages, question titles, and details.
  • Adds dark/light screenshot fixtures covering each region.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
chatQuestionCarousel.css Broadens themed link styling across the carousel.
chatQuestionCarousel.fixture.ts Adds markdown-link visual coverage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: df2411cf Current: 0ba53997

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Added (2)

chat/chatQuestionCarousel/MarkdownLinks/Dark

current

chat/chatQuestionCarousel/MarkdownLinks/Light

current

@mrleemurray
Lee Murray (mrleemurray) merged commit c160486 into main Sep 1, 2026
41 checks passed
@mrleemurray
Lee Murray (mrleemurray) deleted the mrleemurray/compact-moccasin-roadrunner branch September 1, 2026 12:51
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hard to read links in question widget in Kimbie dark theme

3 participants