Skip to content

agentHost: preserve complete multi-root changes summary - #333703

Merged
Don Jayamanne (DonJayamanne) merged 1 commit into
mainfrom
don/agents/issue-332694-root-cause-analysis
Sep 2, 2026
Merged

agentHost: preserve complete multi-root changes summary#333703
Don Jayamanne (DonJayamanne) merged 1 commit into
mainfrom
don/agents/issue-332694-root-cause-analysis

Conversation

@DonJayamanne

Copy link
Copy Markdown
Contributor

Summary

  • publish the multi-root all-folder changes summary only when every source succeeds
  • preserve the last complete live and persisted summary when any repository diff is unavailable
  • cover cold-cache and warm-cache partial-failure behavior

Testing

  • npm run compile-client
  • npm run hygiene
  • VSCODE_SKIP_PRELAUNCH=1 ./scripts/test.sh --run src/vs/platform/agentHost/test/node/agentHostChangesetService.test.ts --grep "all-folder branch summary" (12 passing)

Fixes #332694

Keep the last complete all-folder summary when any repository diff is unavailable instead of publishing and persisting a partial aggregate.\n\nRefs #332694

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 1, 2026 02:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Ensures multi-root Agent Host summaries remain complete when repository diffs fail.

Changes:

  • Publishes summaries only when every source succeeds.
  • Preserves cached live and persisted summaries on partial failure.
  • Adds cold- and warm-cache failure coverage.
File Description
agentHostChangesetService.ts Requires complete multi-root diff results.
agentHostChangesetService.test.ts Tests partial-failure preservation behavior.
Suppressed comments (1)

src/vs/platform/agentHost/node/agentHostChangesetService.ts:995

  • This branch now also handles partial, but the warning still claims that no source was available. That makes partial failures indistinguishable from total failures in diagnostics—the exact scenario this change addresses. Report the actual evaluation outcome and update the comment accordingly.
		if (evaluation.outcome !== 'complete') {
			// No source produced diffs (total failure or no sources at all).
			// Preserve the previously cached summary instead of clobbering it
			// with a spurious zero aggregate.
			this._logService.warn(`[AgentHostChangesetService] No diff source available for multi-folder branch summary ${session}; preserving the cached summary.`);

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@DonJayamanne
Don Jayamanne (DonJayamanne) marked this pull request as ready for review September 1, 2026 02:41
@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit b5a065f into main Sep 2, 2026
38 checks passed
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the don/agents/issue-332694-root-cause-analysis branch September 2, 2026 00:01
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent host: restoring multi-root sessions can fan out Git work until probes time out

3 participants