agentHost: preserve complete multi-root changes summary - #333703
Merged
Don Jayamanne (DonJayamanne) merged 1 commit intoSep 2, 2026
Merged
agentHost: preserve complete multi-root changes summary#333703Don Jayamanne (DonJayamanne) merged 1 commit into
Don Jayamanne (DonJayamanne) merged 1 commit into
Conversation
Keep the last complete all-folder summary when any repository diff is unavailable instead of publishing and persisting a partial aggregate.\n\nRefs #332694 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Don Jayamanne (DonJayamanne)
September 1, 2026 02:29
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Ensures multi-root Agent Host summaries remain complete when repository diffs fail.
Changes:
- Publishes summaries only when every source succeeds.
- Preserves cached live and persisted summaries on partial failure.
- Adds cold- and warm-cache failure coverage.
| File | Description |
|---|---|
agentHostChangesetService.ts |
Requires complete multi-root diff results. |
agentHostChangesetService.test.ts |
Tests partial-failure preservation behavior. |
Suppressed comments (1)
src/vs/platform/agentHost/node/agentHostChangesetService.ts:995
- This branch now also handles
partial, but the warning still claims that no source was available. That makes partial failures indistinguishable from total failures in diagnostics—the exact scenario this change addresses. Report the actual evaluation outcome and update the comment accordingly.
if (evaluation.outcome !== 'complete') {
// No source produced diffs (total failure or no sources at all).
// Preserve the previously cached summary instead of clobbering it
// with a spurious zero aggregate.
this._logService.warn(`[AgentHostChangesetService] No diff source available for multi-folder branch summary ${session}; preserving the cached summary.`);
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Don Jayamanne (DonJayamanne)
marked this pull request as ready for review
September 1, 2026 02:41
Anthony Kim (anthonykim1)
approved these changes
Sep 1, 2026
Don Jayamanne (DonJayamanne)
deleted the
don/agents/issue-332694-root-cause-analysis
branch
September 2, 2026 00:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run compile-clientnpm run hygieneVSCODE_SKIP_PRELAUNCH=1 ./scripts/test.sh --run src/vs/platform/agentHost/test/node/agentHostChangesetService.test.ts --grep "all-folder branch summary"(12 passing)Fixes #332694