Browser: agent-scoped storage - #333694
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (3)
| Severity | Finding |
|---|---|
 |
src/vs/platform/browserView/electron-main/browserSession.ts — Agent sessions now have deterministic IDs, but _createNativeBrowserView still calls… |
 |
src/vs/workbench/contrib/browserView/electron-browser/features/browserDataStorageFeatures.ts — The new agent value is a workbench-owned security/data-sharing control, but this setting has no… |
 |
src/vs/workbench/contrib/browserView/electron-browser/features/browserDataStorageFeatures.ts — This description is not true in the Agents window. Both OpenBrowserTool and Playwright… |
What changed in this PR
Adds agent-scoped, in-memory storage to the integrated browser.
Changes:
- Adds Agent storage identities and session affinity.
- Integrates Agent storage with tools, Playwright, CDP, UI, history, permissions, and zoom.
- Adds unit and API integration coverage.
| File | Description |
|---|---|
src/vs/workbench/services/browserView/electron-browser/playwrightWorkbenchService.ts |
Configures Sessions-window affinity. |
src/vs/workbench/contrib/browserView/test/electron-browser/tools/openBrowserTool.test.ts |
Tests tool affinity behavior. |
src/vs/workbench/contrib/browserView/electron-browser/tools/openBrowserTool.ts |
Applies chat affinity in Agents windows. |
src/vs/workbench/contrib/browserView/electron-browser/features/browserHistoryFeature.ts |
Hides history for Agent sessions. |
src/vs/workbench/contrib/browserView/electron-browser/features/browserDataStorageFeatures.ts |
Adds Agent setting and clear action. |
src/vs/workbench/contrib/browserView/common/browserZoomService.ts |
Generalizes ephemeral zoom handling. |
src/vs/workbench/contrib/browserView/common/browserView.ts |
Applies in-memory zoom semantics. |
src/vs/platform/browserView/test/common/browserView.test.ts |
Tests scope and affinity helpers. |
src/vs/platform/browserView/node/playwrightService.ts |
Applies Playwright session affinity. |
src/vs/platform/browserView/node/playwrightChannel.ts |
Validates and forwards affinity options. |
src/vs/platform/browserView/electron-main/browserViewMainService.ts |
Supplies window identity to sessions. |
src/vs/platform/browserView/electron-main/browserViewGroup.ts |
Creates Agent-backed CDP contexts. |
src/vs/platform/browserView/electron-main/browserSessionPermissions.ts |
Keeps Agent permissions in memory. |
src/vs/platform/browserView/electron-main/browserSessionHistory.ts |
Keeps Agent history in memory. |
src/vs/platform/browserView/electron-main/browserSession.ts |
Implements Agent session identity. |
src/vs/platform/browserView/common/playwrightService.ts |
Extends Playwright initialization options. |
src/vs/platform/browserView/common/browserView.ts |
Defines Agent scope and helpers. |
extensions/vscode-api-tests/src/singlefolder-tests/browser.tools.test.ts |
Tests cookie sharing and isolation. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Kyle Cutler (kycutler)
marked this pull request as ready for review
September 1, 2026 16:59
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Joaquín Ruales (@jruales)Matched files:
|
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Martin Aeschlimann (aeschli)
approved these changes
Sep 1, 2026
Kyle Cutler (kycutler)
enabled auto-merge (squash)
September 1, 2026 18:20
TylerLeonhardt
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.