cli: improve error handling for extension installation failures on running server - #333673
Open
Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
Open
cli: improve error handling for extension installation failures on running server#333673Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
Deniz Güney Yıldırım (denizguney) wants to merge 2 commits into
Conversation
…nning server Enhance `do_extension_install_on_running_server` in `code_server.rs` to capture and propagate standard error output when extension installation fails, rather than failing silently or ignoring command failure status.
Copilot started reviewing on behalf of
Deniz Güney Yıldırım (denizguney)
August 31, 2026 23:07
View session
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if show_editor_link { | ||
| println!( | ||
| " {} {} {}", | ||
| " {} {} {}", |
Update `do_extension_install_on_running_server` in `code_server.rs` to explicitly log error messages via the logger macro and propagate the captured stderr when extension installation fails on a running server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #333670