chat: Improve uninstalled MCP server details - #333664
Merged
Jessie Houghton (houghj16) merged 6 commits intoSep 1, 2026
Merged
Conversation
Explain when MCP server details become available, avoid moving focus on pointer activation, and align the empty state styling with the detail header. Retry gallery loading when the configured manifest becomes available so the Featured section does not remain empty after startup. Fixes #333556. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jessie Houghton (houghj16)
requested review from
Hawk Ticehurst (hawkticehurst)
and
a balanced review from Copilot
August 31, 2026 22:26
Copilot started reviewing on behalf of
Jessie Houghton (houghj16)
August 31, 2026 22:27
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (5)
| Severity | Finding |
|---|---|
 |
src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts — This required service is not registered by the component-fixture setups that construct… |
 |
src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts — Subscribing here does not initialize the manifest service. The browser/no-remote… |
|
src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts — A manifest update while a marketplace search is active cancels that search and clears its results,… |
|
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts — Removing the only focus transfer leaves keyboard focus on the activated server button just as its… |
 |
src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css — This offset does not actually align the message with the detail title described in the PR. In the… |
What changed in this PR
Improves MCP details for uninstalled servers and addresses gallery startup loading.
Changes:
- Adds installation-aware detail messaging and visual coverage.
- Restyles the empty detail state and removes automatic message focus.
- Refreshes gallery data when the manifest changes.
| File | Description |
|---|---|
aiCustomizationManagementEditor.fixture.ts |
Adds an uninstalled-server fixture. |
aiCustomizationManagement.css |
Updates empty-state spacing and styling. |
mcpListWidget.ts |
Handles install state and manifest changes. |
embeddedMcpServerDetail.ts |
Shows installation-specific detail messaging. |
aiCustomizationManagementEditor.ts |
Changes detail focus behavior. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Initialize and refresh gallery state reliably, restore accessible focus navigation, align detail messaging with shared geometry, and register gallery manifest mocks for affected fixtures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Create the MCP detail Back control as an HTMLButtonElement so its stored focus target satisfies the client type check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailWorkspace/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUser/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUser/Light
| Before | After |
|---|---|
 |
 |
1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Added (2)
chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUninstalled/Dark
chat/aiCustomizations/aiCustomizationManagementEditor/EmbeddedMcpDetailUninstalled/Light
Add the Ubuntu-generated blocks-ci hashes for the new uninstalled MCP detail fixture in dark and light themes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hawk Ticehurst (hawkticehurst)
approved these changes
Sep 1, 2026
Jessie Houghton (houghj16)
enabled auto-merge
September 1, 2026 18:31
Jessie Houghton (houghj16)
disabled auto-merge
September 1, 2026 18:31
Jessie Houghton (houghj16)
enabled auto-merge (squash)
September 1, 2026 18:31
Jessie Houghton (houghj16)
deleted the
agents/mcp-server-installation-fix
branch
September 1, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333556
Summary
Screenshots
Validation