Implement subagent default setting to Auto without overriding models - #333663
Draft
SteVen Batten (sbatten) wants to merge 1 commit into
Draft
Implement subagent default setting to Auto without overriding models#333663SteVen Batten (sbatten) wants to merge 1 commit into
SteVen Batten (sbatten) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/workbench/contrib/chat/common/tools/builtinTools/runSubagentTool.ts — When agentName is omitted, subagent is always undefined, even though this tool inherits the… |
 |
src/vs/workbench/contrib/chat/test/common/tools/builtinTools/runSubagentTool.test.ts — This and the following direct-invocation Auto test are inside the nested subagent depth tracking… |
What changed in this PR
Adds an experimental setting to default eligible local subagents to Copilot Auto while preserving explicit, agent-configured, and BYOK model selections.
Changes:
- Registers
chat.subagents.defaultToAuto. - Adds cache-first Auto model resolution and eligibility checks.
- Expands model precedence, fallback, and routing tests.
| File | Description |
|---|---|
chat.shared.contribution.ts |
Registers the setting. |
constants.ts |
Adds its configuration key. |
runSubagentTool.ts |
Implements Auto model resolution. |
runSubagentTool.test.ts |
Adds routing and fallback coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+540
to
+544
| if ( | ||
| !explicitModelResolved | ||
| && !subagent?.model?.length | ||
| && (!mainModelMetadata || !isByokModel(mainModelMetadata)) | ||
| && this.configurationService.getValue<boolean>(ChatConfiguration.SubagentsDefaultToAuto) === true |
| assert.deepStrictEqual(capturedRequests[0].modeInstructions, currentModeInstructions); | ||
| }); | ||
|
|
||
| test('passes prepared Auto model to participant without resolving it again', async () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new setting,
chat.subagents.defaultToAuto, which allows local subagents to default to the Auto model when no specific model is specified. Key changes include:This change enhances the flexibility of subagent behavior while maintaining existing configurations and ensuring backward compatibility.