Skip to content

html: remove deprecated mirror cursor setting - #333651

Merged
Dmitriy Vasyura (dmitrivMS) merged 1 commit into
mainfrom
dmitriv/remove-unused-mirror-cursor
Sep 1, 2026
Merged

html: remove deprecated mirror cursor setting#333651
Dmitriy Vasyura (dmitrivMS) merged 1 commit into
mainfrom
dmitriv/remove-unused-mirror-cursor

Conversation

@dmitrivMS

@dmitrivMS Dmitriy Vasyura (dmitrivMS) commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the deprecated html.mirrorCursorOnMatchingTag setting
  • remove its stale localization strings

The setting has been superseded by editor.linkedEditing and has no runtime consumer.

Validation

  • parsed the edited extension manifest and localization file as JSON
  • verified no remaining references to html.mirrorCursorOnMatchingTag
  • ran git diff --check

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 31, 2026 21:40
@dmitrivMS Dmitriy Vasyura (dmitrivMS) added html HTML support issues debt Code quality issues labels Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Removes the obsolete HTML mirror-cursor setting and its localization strings.

Changes:

  • Removes html.mirrorCursorOnMatchingTag from the extension manifest.
  • Removes the corresponding localization entries.
File Description
extensions/​html-language-features/​package.json Removes the deprecated setting declaration.
extensions/​html-language-features/​package.nls.json Removes unused localization strings.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@aeschli

Copy link
Copy Markdown
Contributor

Thanks Dmitriy Vasyura (@dmitrivMS) !

@dmitrivMS
Dmitriy Vasyura (dmitrivMS) merged commit 2fede32 into main Sep 1, 2026
39 checks passed
@dmitrivMS
Dmitriy Vasyura (dmitrivMS) deleted the dmitriv/remove-unused-mirror-cursor branch September 1, 2026 18:00
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debt Code quality issues html HTML support issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants