Skip to content

chat: remove deprecated agent debug log setting - #333650

Merged
Dmitriy Vasyura (dmitrivMS) merged 1 commit into
mainfrom
dmitriv/remove-unused-agent-debug-log
Sep 1, 2026
Merged

chat: remove deprecated agent debug log setting#333650
Dmitriy Vasyura (dmitrivMS) merged 1 commit into
mainfrom
dmitriv/remove-unused-agent-debug-log

Conversation

@dmitrivMS

@dmitrivMS Dmitriy Vasyura (dmitrivMS) commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the deprecated github.copilot.chat.agentDebugLog.enabled setting
  • remove its completed migration registration, localization, and stale core constant/comment
  • retain github.copilot.chat.agentDebugLog.fileLogging.enabled as the authoritative extension-host debug logging toggle

This does not change the separate chat.agentHost.agentDebugLog.enabled setting used by agent host sessions.

Validation

  • parsed the edited extension manifests as JSON
  • verified no remaining references to the removed setting or constants
  • ran git diff --check

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 31, 2026 21:38
@dmitrivMS Dmitriy Vasyura (dmitrivMS) added debt Code quality issues chat labels Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Balanced
Findings: None

What changed in this PR

Removes the deprecated agent debug logging setting while preserving the authoritative file-logging and separate agent-host settings.

Changes:

  • Removes the deprecated setting, migration, localization, and constant.
  • Retains file logging as the extension-host debug toggle.
  • Removes obsolete explanatory commentary.
File Description
src/​vs/​workbench/​contrib/​chat/​common/​promptSyntax/​promptTypes.ts Removes the deprecated setting constant.
src/​vs/​workbench/​contrib/​chat/​common/​chatService/​chatServiceImpl.ts Removes stale migration commentary.
extensions/​copilot/​src/​platform/​configuration/​common/​configurationService.ts Removes deprecated configuration registration and migration.
extensions/​copilot/​package.nls.json Removes obsolete localization entries.
extensions/​copilot/​package.json Removes the deprecated setting contribution.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@dmitrivMS
Dmitriy Vasyura (dmitrivMS) merged commit 39767fd into main Sep 1, 2026
39 checks passed
@dmitrivMS
Dmitriy Vasyura (dmitrivMS) deleted the dmitriv/remove-unused-agent-debug-log branch September 1, 2026 17:36
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chat debt Code quality issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants