Skip to content

sessions: move code review next to diff stats in single-pane Changes header#325701

Merged
sandy081 merged 1 commit into
mainfrom
sandy081/agents/move-code-review-next-to-diff-stats
Jul 13, 2026
Merged

sessions: move code review next to diff stats in single-pane Changes header#325701
sandy081 merged 1 commit into
mainfrom
sandy081/agents/move-code-review-next-to-diff-stats

Conversation

@sandy081

Copy link
Copy Markdown
Member

What changed

In the Agents window single side-pane view, the Run Code Review action now sits in the primary (left) editor header next to the diff-stats action, in its own menu group so a separator renders before it (Branch Changes picker + diff-stats | Run Code Review).

The diff-stats action now always renders the rich, clickable "N files +X -Y" pill:

  • Previously there were two variants: a non-interactive "N files +X -Y" label shown while the editor area was open, and a clickable "+X -Y" pill shown only when the editor area was collapsed.
  • These are unified into a single interactive rich pill that renders regardless of editor-area visibility. Clicking it opens/re-opens the Changes editor.

Why

Consolidates the diff-stats rendering into one consistent, always-clickable control and groups the code review action alongside it in the left header (previously it lived on the right in SessionsEditorHeaderSecondary).

Notes for reviewers

  • RunSessionCodeReviewAction's single-pane contribution moved from Menus.SessionsEditorHeaderSecondary (order 10) to Menus.SessionsEditorHeaderPrimary, group 1_codeReview — the separate group is what produces the divider before it.
  • Removed the now-dead ChangesDiffStatsLabelAction and the non-interactive onClick/focus overrides; SinglePaneChangesDiffStatsActionItem is now fully interactive.
  • Cleaned up the corresponding dead CSS and fixed the header separator margin in style.css.
  • The classic (non-single-pane) layout is unaffected — code review still contributes to MenuId.AgentsChangesToolbar.
  • LAYOUT.md updated to match.

…header

In the Agents window single side-pane view, move the Run Code Review
action into the primary (left) editor header next to the diff-stats
action, in its own menu group so a separator renders before it.

The diff-stats action now always renders the rich, clickable "N files
+X -Y" pill (previously only shown when the editor area was collapsed;
a separate non-interactive label was shown when it was open). Clicking
it opens/re-opens the Changes editor regardless of editor-area state.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 13, 2026 21:46
@sandy081 sandy081 self-assigned this Jul 13, 2026
@sandy081 sandy081 enabled auto-merge (squash) July 13, 2026 21:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves single-pane Changes header actions into a consistent layout.

Changes:

  • Places code review beside diff statistics.
  • Makes rich diff statistics always interactive.
  • Updates styling and layout documentation.
Show a summary per file
File Description
src/vs/sessions/LAYOUT.md Updates header documentation.
codeReview.contributions.ts Moves code review to the primary header.
sessionChangesEditor.css Enables interactive pill styling.
changesView.ts Unifies diff-stat actions.
style.css Adjusts separator margins.

Review details

  • Files reviewed: 5/5 changed files
  • Comments generated: 4
  • Review effort level: Medium

Comment thread src/vs/sessions/contrib/changes/browser/changesView.ts
Comment thread src/vs/sessions/browser/media/style.css
Comment thread src/vs/sessions/LAYOUT.md
Comment thread src/vs/sessions/contrib/changes/browser/changesView.ts
@sandy081 sandy081 merged commit 60a6854 into main Jul 13, 2026
30 checks passed
@sandy081 sandy081 deleted the sandy081/agents/move-code-review-next-to-diff-stats branch July 13, 2026 23:19
@vs-code-engineering vs-code-engineering Bot added this to the 1.130.0 milestone Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants