🧹 Remove isSessionTypeVisible from ChatInputPart#325697
Merged
Merged
Conversation
The `_isVisible` override in SessionTypePickerActionItem duplicated the Extension Host Copilot CLI hide check that isVisibleEditorChatSessionType already performs (keyed on the same chat.editor.copilotCli.hideExtensionHost setting). It also introduced an isSessionTypeVisible delegate hook that no delegate ever implemented. Restore _isVisible to the pre-#323914 one-liner that defers to the shared isVisibleEditorChatSessionType, and drop the now-dead isSessionTypeVisible member from the picker delegate interface. No behavior change: the hide rule remains centralized in isVisibleEditorChatSessionType. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 53512dbc-d36f-4137-b6fe-739338b4844b
The IAutomationSessionTypeProvider abstraction was registered as a singleton but never injected or called by anyone. It was intended as the layering seam for a workbench-side automations UI to reach the Sessions layer, but the automations dialog lives in vs/sessions and drives its session-type picker (MobileSessionTypePicker) directly against ISessionsManagementService. getSessionTypesForFolder, bypassing the bridge entirely. Delete the interface, its IAutomationSessionTypeChoice type, the AutomationSessionTypeProvider implementation, and the singleton registration. No behavior change: the live path was always the sessions picker. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 53512dbc-d36f-4137-b6fe-739338b4844b
Contributor
There was a problem hiding this comment.
Pull request overview
Removes obsolete automation-specific session-type filtering and its now-unused provider bridge.
Changes:
- Removes
isSessionTypeVisiblefrom the picker delegate. - Uses the shared editor session-type visibility logic.
- Deletes unused automation session-type services and registration.
Show a summary per file
| File | Description |
|---|---|
automationSessionTypes.ts |
Removes the obsolete service contract. |
sessionTargetPickerActionItem.ts |
Uses shared visibility filtering exclusively. |
chat.ts |
Removes the delegate visibility callback. |
automationSessionTypeProvider.ts |
Removes the unused Sessions-layer implementation. |
automations.contribution.ts |
Removes obsolete service registration. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Medium
pwang347
approved these changes
Jul 13, 2026
eleanorjboyd
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reducing debt created in #323914
After much refactoring, the following logic can be entirely reverted / deleted.