Respect explorer.compactFolders in the search results tree#325654
Open
dobbydobap wants to merge 1 commit into
Open
Respect explorer.compactFolders in the search results tree#325654dobbydobap wants to merge 1 commit into
dobbydobap wants to merge 1 commit into
Conversation
| ], | ||
| this.searchDataSource, | ||
| { | ||
| compressionEnabled: this.configurationService.getValue<boolean>('explorer.compactFolders'), |
Comment on lines
+1013
to
+1014
| this._register(Event.filter(this.configurationService.onDidChangeConfiguration, e => e.affectsConfiguration('explorer.compactFolders'))(() => | ||
| this.tree.updateOptions({ compressionEnabled: this.configurationService.getValue<boolean>('explorer.compactFolders') }))); |
Contributor
Author
There was a problem hiding this comment.
Good catch, I'd only mirrored half of the Explorer's isCompressionEnabled. Added the screen-reader-optimized guard to compressionEnabled and a matching onDidChangeScreenReaderOptimized subscription so both update paths recompute together, same as explorerView. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301832. The Search view's results tree (
WorkbenchCompressibleAsyncDataTree) never setcompressionEnabled, so it always compacted single-child folders regardless ofexplorer.compactFolders. This reads the setting at construction and updates on change, mirroring how the Explorer view already does it no new setting, just honoring the existing one in Search too.