Fix file handle leak in zip extraction when the source stream errors#325585
Open
aturzone wants to merge 1 commit into
Open
Fix file handle leak in zip extraction when the source stream errors#325585aturzone wants to merge 1 commit into
aturzone wants to merge 1 commit into
Conversation
extractEntry() pipes the zip entry's read stream into a createWriteStream target. stream.pipe(istream) does not destroy the destination when the source errors, so on a corrupt/truncated entry the source 'error' handler rejected the promise but left istream (the target file handle) open, leaking the fd and a partially-written file. The cancellation path already destroys istream; the source-error path did not. Destroy istream in the source 'error' handler, mirroring the existing cancellation cleanup. Assisted-by: Claude Code (Opus 4.8)
Comment on lines
+98
to
+100
| // `stream.pipe()` does not destroy the destination when the | ||
| // source errors, so close the target file handle explicitly to | ||
| // avoid leaking it (mirrors the cancellation path above). |
| // `stream.pipe()` does not destroy the destination when the | ||
| // source errors, so close the target file handle explicitly to | ||
| // avoid leaking it (mirrors the cancellation path above). | ||
| istream.destroy(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extractEntry() pipes the zip entry's read stream into a createWriteStream target. stream.pipe(istream) does not destroy the destination when the source errors, so on a corrupt/truncated entry the source 'error' handler rejected the promise but left istream (the target file handle) open, leaking the fd and a partially-written file. The cancellation path already destroys istream; the source-error path did not.
Destroy istream in the source 'error' handler, mirroring the existing cancellation cleanup.
Assisted-by: Claude Code (Opus 4.8)